Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: RDS Cluster additions #3757

Merged
merged 4 commits into from
Nov 5, 2015
Merged

provider/aws: RDS Cluster additions #3757

merged 4 commits into from
Nov 5, 2015

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 4, 2015

Adding backup_retention_period, preferred_backup_window and preferred_maintenance_window to RDS Cluster

Fixes #3755

make testacc TEST=./builtin/providers/aws TESTARGS='-run=RDSCluster_' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=RDSCluster_ -timeout 90m
=== RUN   TestAccAWSRDSCluster_basic
--- PASS: TestAccAWSRDSCluster_basic (112.39s)
=== RUN   TestAccAWSRDSCluster_backups
--- PASS: TestAccAWSRDSCluster_backups (111.10s)
=== RUN   TestAccAWSRDSCluster_backupsUpdate
--- PASS: TestAccAWSRDSCluster_backupsUpdate (125.92s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    349.436s

@stack72 stack72 mentioned this pull request Nov 4, 2015
Closed
@stack72
Fixing the spelling mistakes and adding a test to prove that the Upda…
4e485d4 
…tes to the new properties of RDS Cluster work as expected
catsby
catsby reviewed Nov 4, 2015
View reviewed changes
builtin/providers/aws/resource_aws_rds_cluster.go
@@ -156,6 +184,18 @@ func resourceAwsRDSClusterCreate(d *schema.ResourceData, meta interface{}) error
createOpts.AvailabilityZones = expandStringList(attr.List())
}

if v, ok := d.GetOk("backup_retention_period"); ok {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to leave, but fwiw anything with a Default specified will always return true for ok in d.GetOk

@catsby
Copy link
Contributor

catsby commented Nov 4, 2015

Left some feedback, otherwise looks good! Let me know what you think about those proposed changes

@catsby catsby added enhancement waiting-response An issue/pull request is waiting for a response from the community provider/aws labels Nov 4, 2015
@stack72
Copy link
Contributor Author

stack72 commented Nov 5, 2015

@catsby you are correct on these changes. I tend to bunch the tests too much. Just made the changes :)

Thanks for the useful feedback here. It's stuff I can use in other PRs

@catsby
Copy link
Contributor

catsby commented Nov 5, 2015

Thanks for following up there. Sorry for the run around, but let's ditch TestAccAWSRDSCluster_backups and just have the latter one TestAccAWSRDSCluster_backupsUpdate (sp). The first test case of the latter is identical to the only test case in the former, sound good?

@stack72
Copy link
Contributor Author

stack72 commented Nov 5, 2015

makes sense - no need for a duplicate test :) Sorted now @catsby

@catsby
Copy link
Contributor

catsby commented Nov 5, 2015

Thanks!

catsby added a commit that referenced this pull request Nov 5, 2015
@catsby
Merge pull request #3757 from stack72/f-aws-rds-cluster-backup
cb52e23 
provider/aws: RDS Cluster additions
@catsby catsby merged commit cb52e23 into hashicorp:master Nov 5, 2015
@stack72 stack72 deleted the f-aws-rds-cluster-backup branch November 8, 2015 16:23
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_rds_cluster: backup_retention_period is not actually supported
2 participants
@stack72 @catsby